Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support reserving standby Nodes from dedicated machines #2213

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

AlaaElattar
Copy link
Contributor

@AlaaElattar AlaaElattar commented Feb 20, 2024

Description

currently, the dashboard allows renting only the online nodes, but now threefoldtech/tfchain#923 and the famerbot can wake the rented node up if the farm has an up-and-running farmerbot (can ping the farmerbot before renting to make sure it's running). So besides showing the online nodes, the dashboard should also show the standby nodes.

Changes

  • from rentable tab, all nodes will be online and standby nodes.

Related Issues

#2143

  • Note that there'so screenshots as for now no standby nodes available for renting.

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

standby node appears on rent-able tab, should be fine.
great job thank you Alaa

image
image

@AlaaElattar AlaaElattar merged commit 8fc8246 into development_314 Feb 26, 2024
3 checks passed
@AlaaElattar AlaaElattar deleted the development_314_standby branch February 26, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants